Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch notification when load setting page #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

xjiang-at-wiris
Copy link

@xjiang-at-wiris xjiang-at-wiris commented May 2, 2024

Description

Fix error for MathType for TinyMCE (legacy) warning, that can be displayed multiple times on the Site administration.

Steps to reproduce

(If this is your first time running Moodle, please following this instruction to configure: https://github.com/wiris/wiris-moodle-docker/blob/main/README.md)

  1. Use Moodle > 4.1.
  2. MathType for TinyMCE (legacy) is installed
  3. Log in Moodle as an admin
  4. Go to Site Administration
  5. Go to Plugins > Filter > MathType by WIRIS
  6. Change Render Type from Client to PHP.
  7. Check that the warning only shows one time

taskid 44423

settings.php Outdated Show resolved Hide resolved
Copy link
Contributor

@carla-at-wiris carla-at-wiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following error appears when trying to change the Filter configuration:

Error output, so disabling automatic redirect.

Script /admin/settings.php?section=filtersettingwiris mutated the session after it was closed: $SESSION->cachestore_session: default_session-core/coursecat,default_session-core/courseeditorstate,default_session-core/navigation_expandcourse $SESSION->navcache
line 793 of /lib/classes/session/manager.php: call to debugging()
line 162 of /lib/classes/shutdown_manager.php: call to core\session\manager::check_mutated_closed_session()
line ? of unknownfile: call to core_shutdown_manager::shutdown_handler()

It stays then on an infinite loop, not letting me apply any change to the configuration.
The warning does not appear either.

@xjiang-at-wiris
Copy link
Author

xjiang-at-wiris commented May 8, 2024

The following error appears when trying to change the Filter configuration:

Error output, so disabling automatic redirect.

Script /admin/settings.php?section=filtersettingwiris mutated the session after it was closed: $SESSION->cachestore_session: default_session-core/coursecat,default_session-core/courseeditorstate,default_session-core/navigation_expandcourse $SESSION->navcache
line 793 of /lib/classes/session/manager.php: call to debugging()
line 162 of /lib/classes/shutdown_manager.php: call to core\session\manager::check_mutated_closed_session()
line ? of unknownfile: call to core_shutdown_manager::shutdown_handler()

It stays then on an infinite loop, not letting me apply any change to the configuration. The warning does not appear either.

Hi, the error isn't caused by this commit. I changed the filter to stable branch and still encountered this error.

It seems to be a native error in Moodle, and it's resolved in versions after 402.

I found info in this thread

https://tracker.moodle.org/browse/MDL-80735?focusedId=1058774&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1058774
(I tried 403, and indeed, the error no longer occurs).

@carla-at-wiris carla-at-wiris self-requested a review May 9, 2024 12:11
Copy link
Contributor

@usantos-at-wiris usantos-at-wiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants