Refactor moodle test page. #144
Conversation
xjiang-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
a user,
usantos-at-wiris and
psala-at-wiris
There was a problem hiding this comment.
@xjiang-at-wiris I checked the code and I think I will need your help to understand how these changes affect the test pages. On the other hand, code seems fine to me, to let's meet and test it out together ok? Thanks, great job! 💪🏾
| @@ -40,14 +40,12 @@ | |||
| $string['clearcachedesc'] = 'Clear MathType filter cache'; | |||
| $string['clickwirisplugincorrectlyinstalled'] = 'Click the following button to test if MathType is correctly installed.'; | |||
| $string['clickwirisquizzescorrectlyinstalled'] = 'Click the following button to test if WirisQuizzes is correctly installed.'; | |||
| $string['contact'] = 'For more information or if you have any doubt contact WIRIS Support:'; | |||
| $string['contact'] = 'For more information see <a href="https://docs.wiris.com/mathtype/en/mathtype-for-lms/mathtype-for-moodle.html">our documentation </a> or contact WIRIS Support:'; | |||
There was a problem hiding this comment.
Maybe this will conflict when changing the Moodle language. I'll check what happens when it is in another one and let you know!
There was a problem hiding this comment.
Sure! I found that the language has a cache, so if the language is not updated, the cache needs to be purged. I will add this step in the "steps to reproduce." But how can we make users do it?
info.php
Outdated
| // Construct table | ||
| table_open(); |
There was a problem hiding this comment.
| // Construct table | |
| table_open(); | |
| // Construct HTML table | |
| table_open(); |
Hablado por Slack, resuelta la confusión sobre que tabla trataba. Añadiendo que es una tabla HTML al comentario se tiene ese contexto.
xjiang-at-wiris
force-pushed
the
KB-43810
branch
from
be0cb5a
to
4ac5d17
Compare
xjiang-at-wiris
requested review from
carla-at-wiris,
jgonzalez-at-wiris and
psala-at-wiris
| @@ -213,22 +212,22 @@ function get_mt_filter_enabled($existsfilter){ | |||
| return $filterenabled; | |||
| } | |||
|
|
|||
| function get_exists_editor($editorname) { | |||
| function get_editor_exists_and_enabled($editorname) { | |||
There was a problem hiding this comment.
Maybe a clearer name ? Like editor_exists_and_enabled if the return is true or false. In my opinion if the name contains get I assume it returns something else than a bool
There was a problem hiding this comment.
You’re right! But doing this would disrupt the all-get pattern... What does everyone think about that?
There was a problem hiding this comment.
I'd leave the name as is, I agree with Ubaldo the name could be improved but in this context is not that important, and keeping the pattern seems more important in this case.
Description
Refactor of the moodle test page.
The result will be similar to this table (won't be the same, the most important is contains all information):
https://docs.google.com/spreadsheets/d/1hMj9gpHXNtPoB1Q9pAHOD2n-fefZYbtgyKcvgmoGh6U/edit#gid=866511881
Steps to reproduce
3.1. If some text are not updated, try purge cache in Site Administration
taskid 43810
CHANGELOG.MD (filter)
refactor: Redesign test page. #43810