A "little" rewrite

[lalmat]

Hi all,

I've done a "little" refactoring of elephant.io. Due to the number of changes, I don't think it's a good thing to pull request without your validation.
I push it on a branch of my fork : https://github.com/lalmat/elephant.io/tree/refactoring

I've tried to follow the Socket.IO 1.0.x philosophy and I've provided a little example to show you how it works.

Due to my lack of free time, I haven't be able to code the tests classes and manage the timeout on the handshake yet... I hope to have the time to do it soon, but maybe you can already try this refactoring and give me your feedback

Thanks.

[Taluu]

Hi,

There are some ideas (I like the fact that the Socket part is decoupled from the Client part), but it seems promising. Even though we try to stick close to PSRs standards, and also have some remarks to make (like the Debug trait... I don't think this should be each times included), but I did not went deeper in your refactoring yet.

But as I said, there seems to be some good ideas. :)

[lalmat]

Thanks !

It was just a try, i'm not a composer expert neither a user of namespaces in Socket.IO, so I think that it will have some strange behaviours in particular conditions.

I'm sure you will do better as soon as you'll get time :)

[lalmat]

Hi,
I was not aware of PSR standards since today (yup, shame on me.), I'll do my best to stick to them. Thanks @Taluu to highlighted this to me.

[sroze]

@Taluu all of your methods declarations aren't PSR-3-compliant ;-)

[Taluu]

PSR-3 is just logging interface, which doesn't concern us. :)

And if you meant PSR-2, this lib was made way before the PSRs, but this problem should be solved in 3.0. :)

[sroze]

Yep, it was a typo ! Any idea about release date of that 3.0 version (with socket.io 1.0 support I imagine) ?

[Taluu]

Just started working on it (like 10 minutes ago). But I don't have any insights on when we'll do the release, as I have a small window of time to do that, but I'll try to get some POC done next week.

It should have 0.x and 1.x support.

[Taluu]

As the 3.0 was released as a beta, and as I based my work on what you did, I think it is safe to close this ticket.

Thanks ! :)