Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every request fails: missing field chain #10

Closed
0atman opened this issue Jan 12, 2021 · 7 comments
Closed

Every request fails: missing field chain #10

0atman opened this issue Jan 12, 2021 · 7 comments

Comments

@0atman
Copy link

0atman commented Jan 12, 2021

certstream seem to have changed their API:

[2020-12-10][16:31:43] Received unknown message: missing field `chain` at line 1 column 1813
[2020-12-10][16:31:43] Received unknown message: missing field `chain` at line 1 column 1919
[2020-12-10][16:31:43] Received unknown message: missing field `chain` at line 1 column 1606
[2020-12-10][16:31:43] Received unknown message: missing field `chain` at line 1 column 1794
@0atman
Copy link
Author

0atman commented Jan 12, 2021

Confirmed, the api for Certstream has changed to no longer include chain https://certstream.calidog.io/example.json

@0atman
Copy link
Author

0atman commented Jan 12, 2021

This was caused by upstream CaliDog/certstream-server#56

@0atman
Copy link
Author

0atman commented Jan 12, 2021

our workaround has been to remove chain from the data model, and then remove all code that expected it. (we're only interested in domain names for our usage)
https://github.com/wisespace-io/nettfiske/blob/master/src/data.rs#L10

@wisespace-io
Copy link
Owner

@0atman thank you for troubleshooting the issue. I will remove the Chain Object.

@0atman
Copy link
Author

0atman commented Jan 12, 2021

Thank you for making this great library :-)

@d-Rickyy-b
Copy link

Hi there, just wanted to note, that the chain object is still available but only for the full stream: wss://certstream.calidog.io/full-stream

So you can still use the chain (if you want) - you just need to parse it differently.
Compare these two json samples from the live certstream API at certstream.calidog.io:

full-stream vs. regular stream

@wisespace-io
Copy link
Owner

@d-Rickyy-b I can add again in a near future. Thank you for pointing out it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants