Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fixes #2

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Initial fixes #2

merged 2 commits into from
Jul 17, 2019

Conversation

aurpine
Copy link
Contributor

@aurpine aurpine commented Jul 17, 2019

CI now passes

  • Add comments for linting
  • Fix cmd structure to not create config in tests

- Add comments
- Fix other lint/vet warnings
- Remove config file creation in init
- TODO: support custom config
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bca7801). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   37.29%           
=========================================
  Files             ?       27           
  Lines             ?      622           
  Branches          ?        0           
=========================================
  Hits              ?      232           
  Misses            ?      379           
  Partials          ?       11
Impacted Files Coverage Δ
cmd/util/parsing/options.go 100% <ø> (ø)
pkg/client/cronjobutil.go 0% <ø> (ø)
pkg/client/execinpod.go 0% <ø> (ø)
pkg/client/client.go 42.3% <ø> (ø)
pkg/client/runcronjob.go 0% <ø> (ø)
pkg/client/filter/labels.go 100% <ø> (ø)
pkg/client/logpods.go 0% <ø> (ø)
pkg/client/contextsinterface.go 100% <ø> (ø)
cmd/logs.go 0% <0%> (ø)
cmd/root.go 0% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca7801...ac62ca8. Read the comment docs.

@aurpine aurpine merged commit a2936a6 into master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant