Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hostname to lower case to meet K8 naming constraints #40

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

phariharan-wish-zz
Copy link
Contributor

Issue

Hostname with upper case alphanumeric characters will fail the K8 naming validation

Invalid value: "merchant-oneoff-pod-Priyanka-local": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

Fix

Convert hostname to lower case on login, up, down, and cp.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #40 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   33.04%   32.98%   -0.07%     
==========================================
  Files          52       52              
  Lines        2082     2086       +4     
==========================================
  Hits          688      688              
- Misses       1366     1370       +4     
  Partials       28       28              
Impacted Files Coverage Δ
cmd/cp.go 0.00% <0.00%> (ø)
cmd/down.go 0.00% <0.00%> (ø)
cmd/login.go 0.00% <0.00%> (ø)
cmd/up.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e07941...1133a48. Read the comment docs.

@vsakhart vsakhart merged commit 9e9105c into wish:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants