Improve node bootstrap time with node-authorizer and protokube in s3 #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
node-authorizer
and a protokube image that must be pulled via http, node bootstrap takes more than 5 minutes because the order of dependencies is screwed up. What happens is:/etc/hosts
, and kubelet fails because node-authorizer hasn't completed its taskLoadImage.protokube
task that loads protokube, and restarts node-authorizerWith this patch:
Node bootstrap now takes ~2 minutes.
I have tested this patch, and it works at least in our setup, but I don't know if this is unsound in other configurations. In particular, I noticed that kops seemed to depend on node-authorizer either failing or succeeding to make progress. If we didn't load the protokube image before starting node-authorizer, kops would hang indefinitely and never bootstrap.