Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: Crash Opening Shops #113

Closed
RyanSalad opened this issue Nov 30, 2023 · 2 comments
Closed

Re: Crash Opening Shops #113

RyanSalad opened this issue Nov 30, 2023 · 2 comments
Labels
priority: high this issue breaks critical functionality - it must be adressed immediately status: confirmed this issue is reproducible or otherwise confirmed to exist type: bug this issue breaks or otherwise adversely affects functionality

Comments

@RyanSalad
Copy link

RyanSalad commented Nov 30, 2023 •
edited
Loading

Minecraft 1.19.2
Fabric 0.15.0
Numismatic Overhaul 0.2.9
owo-lib 0.9.3
I had decided to bite the bullet and not use Charm, but it started crashing again. I hadn't changed anything, and the only mods left are Fabric API, owo-lib, and Numismatic Overhaul
crash-2023-11-30_05.54.18-server.txt

It is not my intention to nag, but the fix that was told to me previously does not work, and this issue should get resolved by someone eventually considering it has to be an owo-lib or Numismatic Overhaul issue by process of elimination.
Originally posted by me in #112 (comment)
gliscowo added a commit that referenced this issue Dec 2, 2023
@gliscowo
remove erroneous '@Environment(EnvType.SERVER)' on ShopScreenHandler.…
a5b5078 
…shop to fix compatibility with fabric loader >=0.15.0 (#113)
@gliscowo gliscowo added type: bug this issue breaks or otherwise adversely affects functionality priority: high this issue breaks critical functionality - it must be adressed immediately status: confirmed this issue is reproducible or otherwise confirmed to exist labels Dec 2, 2023
@gliscowo
Copy link
Member

gliscowo commented Dec 2, 2023

Thanks for reporting this problem!

As it turns out, this has been a long-standing bug in the Shop's code that never manifested due to a related bug in Fabric Loader itself - which is why it occured when you updated to 0.15.0. I've now gone an published an update which fixes that problem on latest

For your case specifically, I'd recommend simply downgrading Fabric Loader - for now this should not cause problems. I'll see about getting a release with the fix out for 1.19.2 as well in the coming days

Cheers

gliscowo added a commit that referenced this issue Dec 9, 2023
@gliscowo
remove erroneous '@Environment(EnvType.SERVER)' on ShopScreenHandler.…
9fbf247 
…shop to fix compatibility with fabric loader >=0.15.0 (#113)
@gliscowo
Copy link
Member

gliscowo commented Dec 9, 2023

Alright, a build for 1.19.2 has been released as 0.2.10 for 1.19
Cheers

@gliscowo gliscowo closed this as completed Dec 9, 2023
Noaaan pushed a commit to Noaaan/numismatic-overhaul that referenced this issue Dec 30, 2023
@gliscowo @Noaaan
remove erroneous '@Environment(EnvType.SERVER)' on ShopScreenHandler.…
42be8aa 
…shop to fix compatibility with fabric loader >=0.15.0 (wisp-forest#113)
@Noaaan Noaaan mentioned this issue Feb 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high this issue breaks critical functionality - it must be adressed immediately status: confirmed this issue is reproducible or otherwise confirmed to exist type: bug this issue breaks or otherwise adversely affects functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gliscowo @RyanSalad