Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule locations #3

Open
bitcoinx2 opened this issue Jun 10, 2018 · 2 comments
Open

Update submodule locations #3

bitcoinx2 opened this issue Jun 10, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@bitcoinx2
Copy link
Member

bitcoinx2 commented Jun 10, 2018

Submodule 'db4.8' (https://github.com/XSPECOfficial/db4.8) registered for path 'db4.8'
Submodule 'leveldb' (https://github.com/XSPECOfficial/leveldb) registered for path 'leveldb'
Submodule 'tor' (https://github.com/spectrecoin/tor.git) registered for path 'tor'
  • The XSPECOfficial repository should probably be removed
  • The Tor submodule should not refer to a repository that is maintained by a different development team, since it might introduce incompatibilities
@bitcoinx2 bitcoinx2 added the bug Something isn't working label Jun 10, 2018
@bitcoinx2
Copy link
Member Author

bitcoinx2 commented Jul 20, 2018

Partially solved by #5 by @sinfulhands , thanks!

Is referring to the Spectrecoin repository actually a problem?

@sinfulhands
Copy link
Contributor

It's not ideal. You run a risk as the two projects diverge of having one of three possibilities occurring.

  • One, they take the repo private.
  • Two, master of one of the repos is somehow altered to account for a change on the spectrecoin project that wisp has not developed for, which creates an external dependency.
  • Or three, nothing happens.

But, it's best to mitigate risk. Anyone with wisp project access should be able to fork the three repos and just change the git submodule url string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants