Fix case clause error #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blatyo
commented
Sep 22, 2019
| %{status_code: status, data: body} | ||
| |> normalize_response | ||
|
|
||
| %HTTPotion.ErrorResponse{} = error -> |
There was a problem hiding this comment.
This is the primary change
blatyo
commented
Sep 22, 2019
| status_code: integer, | ||
| status_txt: binary, | ||
| } | ||
| data: binary, |
There was a problem hiding this comment.
rest of this stuff is formatter changes
blatyo
commented
Sep 22, 2019
|
|
||
| otp_release: | ||
| - "19.3" | ||
| - "20.2" | ||
| - "20.3" |
There was a problem hiding this comment.
or changing dependencies to get things to build
kswin
approved these changes
Sep 23, 2019
|
@MaxPower15 I assume you're the one with power to publish? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSQ can be flaky over the network. If the request times out, it causes a case clause match error causing the process to crash. If the network remains flaky, the failure can cascade up the supervision tree, causing the whole application to crash.