Fix socket options for newest elixir-socket package #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a fix for issue #6. The problem was that the option handling was sneakily changed in this innocuous "fix warnings" commit to elixir-socket. Now, instead of silently ignoring any unknown options to
Socket.connect
it barfs when the pattern match fails. The handling ofsend_timeout
was also changed so that now an embedded keyword list is needed. The other thing I noticed is that thedeliver: : term
option was never passed through to:inet.setopts/2
even in the earlier versions of elixir-socket so I removed it.Just as a side note: I didn't have a lot of confidence in this library after taking a closer look at the code and the complete absence of tests wasn't very convincing either. It may be worth considering whether or not it's worth cutting the dependency completely and just using gen_tcp directly. Thoughts?