Added number of entities as parameter for message #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed author email
Fixed author email
blandinw
suggested changes
Oct 16, 2017
wit/wit.py
Outdated
| @@ -71,10 +71,12 @@ def __init__(self, access_token, actions=None, logger=None): | |||
| self.logger.error('Stories and POST /converse have been deprecated. This will break in February 2018!') | |||
| self.actions = validate_actions(self.logger, actions) | |||
|
|
|||
| def message(self, msg, context=None, verbose=None): | |||
| def message(self, msg, context=None, num=None, verbose=None): | |||
There was a problem hiding this comment.
num -> n, let's keep the naming consistent between the Python keyword arguments and the HTTP API
wit/wit.py
Outdated
| params = {} | ||
| if verbose: | ||
| params['verbose'] = True | ||
| if num: |
There was a problem hiding this comment.
let's test for is not None instead, to allow 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added number of entities returned as a parameter for .message()