Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new function 'intent_list' #153

Merged
merged 2 commits into from
May 26, 2021
Merged

Added new function 'intent_list' #153

merged 2 commits into from
May 26, 2021

Conversation

Sharan-Babu
Copy link
Contributor

Returns names of all intents associated with your app.

Returns names of all intents associated with your app.
@chessai
Copy link
Contributor

chessai commented May 25, 2021

This looks good, except I think we want to add the optional arguments 'headers=None' and 'verbose=None' to the arguments of intent_list. Something like:

    def intent_list(self, headers=None, verbose=None):
        """
        Returns names of all intents associated with your app.
        """
        params = {}
        headers = headers or {}
        if verbose:
            params['verbose'] = True
        resp = req(self.logger, self.access_token, 'GET', '/intents', params, headers=headers)
        return resp 

@Sharan-Babu
Copy link
Contributor Author

Hi, I have added the optional arguments. Please let me know how it looks now.
I am planning to add functions for all the other API methods as well. Does that sound good?

I also have an idea which is to implement a PR system for Wit apps to make it easy for a large number of people to collaborate. Imagine, people sending pull requests with new utterances for an intent, and they get queued for training if merged by repo maintainer. Right now, you can only give full access to your app by letting others join as a contributor. Is this a good idea?

@Sharan-Babu
Copy link
Contributor Author

2 doubts:

  1. Is this an active repo?
  2. If I want to create an unofficial wrapper with additional functionalities on top of Wit, could I use this repo (along with the license) as a base for that?

@chessai chessai merged commit 6d3bb1f into wit-ai:master May 26, 2021
@chessai
Copy link
Contributor

chessai commented May 26, 2021

2 doubts:

  1. Is this an active repo?
  2. If I want to create an unofficial wrapper with additional functionalities on top of Wit, could I use this repo (along with the license) as a base for that?
  1. Yes this is an active repo, though much of the time we are busy dealing with other things internally, so not paying enough attention to the external clients. I am going to be working on improving the situation over the next few months

  2. You are free to create whatever you want, so long as proper licensing is given if you use our code.

@chessai
Copy link
Contributor

chessai commented May 26, 2021

Hi, I have added the optional arguments. Please let me know how it looks now.
I am planning to add functions for all the other API methods as well. Does that sound good?

I also have an idea which is to implement a PR system for Wit apps to make it easy for a large number of people to collaborate. Imagine, people sending pull requests with new utterances for an intent, and they get queued for training if merged by repo maintainer. Right now, you can only give full access to your app by letting others join as a contributor. Is this a good idea?

  1. Yes, that sounds great!

  2. Yes, that seems like a good idea, though I haven't had time to think about the specifics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants