Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weights for 'gdp' is defined twice #6

Closed
lolow opened this issue Mar 23, 2020 · 3 comments
Closed

weights for 'gdp' is defined twice #6

lolow opened this issue Mar 23, 2020 · 3 comments
Assignees

Comments

@lolow
Copy link
Member

lolow commented Mar 23, 2020

Should we use the SSP source or the IMF source?

@JohannesEmm
Copy link
Member

I would say WDI should be used as is what we use for our gdp calibration.
Also I cleaned up the weights in the branch https://github.com/witch-team/witchtools/tree/witch17eums

@lolow
Copy link
Member Author

lolow commented Mar 23, 2020 via email

@JohannesEmm
Copy link
Member

ok great!
ONe more thing/feature request: I think would be good to have a fall back where if piggyback doesn't have the file looks at witch-data and in case finds it uses this data including printing a warning, could be good for new data asily ading it without first uploading on the release while using the standard data from github

@lolow lolow closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants