addresses review comments

withastro · Mar 26, 2024 · 1d514bc · 1d514bc
1 parent df4a5dc
commit 1d514bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/cloudflare/src/index.ts b/packages/cloudflare/src/index.ts
@@ -151,7 +151,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
 					vite.build ||= {};
 					vite.build.rollupOptions ||= {};
 					vite.build.rollupOptions.output ||= {};
-					// @ts-ignore
+					// @ts-expect-error
 					vite.build.rollupOptions.output.banner ||= 'globalThis.process ??= {};';
 
 					vite.build.rollupOptions.external = _config.vite?.build?.rollupOptions?.external ?? [];

diff --git a/packages/cloudflare/src/utils/wasm-module-loader.ts b/packages/cloudflare/src/utils/wasm-module-loader.ts
@@ -31,6 +31,7 @@ export function wasmModuleLoader({
 				assetsInclude: ['**/*.wasm?module'],
 				build: {
 					rollupOptions: {
+						// mark the wasm files as external so that they are not bundled and instead are loaded from the files
 						external: [/^__WASM_ASSET__.+\.wasm$/i, /^__WASM_ASSET__.+\.wasm.mjs$/i],
 					},
 				},