Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): shim process.env in edge middleware #255

Merged
merged 4 commits into from
May 7, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented May 6, 2024

Changes

Netlify Edge Functions don't define process.env, but Vite uses it for any code that accesses import.meta.env. This PR imports the Deno node:process polyfill at the top of the bundled middleware edge function

Fixes #254

Testing

Tested with repro site https://github.com/jamesarosen/astro-broken-middleware-demo

Docs

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 1a45eef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/netlify Patch
@test/netlify-hosted-astro-project Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the changeset and formatting needs to be updated, otherwise this lgtm: )

Co-authored-by: Alexander Niebuhr <alexander@nbhr.io>
@alexanderniebuhr alexanderniebuhr merged commit 3fa962d into withastro:main May 7, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request May 7, 2024
@ascorbic ascorbic deleted the netlify-env branch May 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't use env in Netlify edge runtime
2 participants