feat(netlify): Netlify Adapter v4

[Skn0tt]

Changes

This PR overhauls the Netlify adapter, aiming to make best use of Netlifys platform & streamlining config.
Read the changeset for a detailed overview, but here's the main changes:

• Middleware runs on all pages, not just SSR routes, independent of config
• Netlify context automatically available via locals, no need for netlify-edge-middleware.ts file
• Support for Netlify Image CDN
• Removal of On-Demand Builders, because we recommend frameworks to use standard caching headers instead
• Removal of unneeded config options

Testing

Tests were brought up-to-date.

Docs

README was updated.

[lilnasy]

Do you think it's a good idea to offer a mocked netlify context in dev mode?

[Skn0tt]

Do you think it's a good idea to offer a mocked netlify context in dev mode?

That would be nice, I guess! We already mock the context in netlify dev, would be good for that to extend into Astro dev. How could that be implemented?

[lilnasy]

You'll have to add a vite dev server (connect server) middleware, and set request[Symbol.for("astro.locals")]. Here's what it looked like in my PR: 53775ba.

[Skn0tt]

Wow, that's pretty cool! I'll definitely implement that.

[Skn0tt]

Besides that, are there any other changes you'd like me to make @lilnasy @alexanderniebuhr @ematipico? From what i'm seeing, all the big ones are addressed and the only missing thing is the docs review. What else do we need to work towards merging?

[lilnasy]

I will be testing out the functionality later today.

As for the big picture, I would be more conformable if the default story was "node only" - for both SSR and middleware, with edge the opt-in.

[alexanderniebuhr]

Just checking in, I don't have anything to add for now. But I'll make sure to get the docs review this week for you! :)

[Skn0tt]

I've implemented the mocked context in 4d4c245 based off your commit @lilnays. Tried giving you credit for that using Co-Authored-By, but somehow GitHub didn't like it and isn't showing your face on the commit :/

As for the big picture, I would be more conformable if the default story was "node only" - for both SSR and middleware, with edge the opt-in.

Cool, will do! I thought the edge was already opt-in, and docs + comments said that - but I noticed the actual code was making it opt-out. Fixed that in 0ac9466.

[sarah11918]

Whew! A major release is exciting! 🥳

Left some suggestions for docs here! (Note: since there was a comment, yes, informing readers of CHANGES goes in the changeset... and there were a lot, so this is the place for them! The README is for "how things just are" and is NOT the place to discuss changes from past versions. So the content there should just be about how it works now.)

[Skn0tt]

@sarah11918 wow, what a review! I always love docs review because the prose reads so much better after that :D I've made most of the changes you requested, and left comments to the two remaining ones.

[ematipico]

Thank you for addressing all my comments!

[alexanderniebuhr]

Unblocking, since we have docs review

[Skn0tt]

Awesome, thanks for approving! I think now we're only waiting for the docs copy to be finalised.

[alexanderniebuhr]

@Skn0tt Just checking in, if you are ready, I'll do another quick sanity check later tonight and get this merged 🚀

[Skn0tt]

Sounds great! Maybe we can merge today + release early monday, so we can respond better to questions in Discord.

[alexanderniebuhr]

@Skn0tt No problem, I'll coordinate everything, so we can get the release on Monday morning CET timezone! :)

[alexanderniebuhr]

I just did another run through the changes, and they lgtm.
Thank you for the PR! @Skn0tt

I'll get this merged now and released on Monday morning! 🚀

[Skn0tt]

Awesome, thanks for all the reviews! I'll keep an eye on Discord and GitHub for any issues that pop up. If I miss any, feel free to tag me in related issues - happy to help.