implement test

withastro · Jun 7, 2023 · 044f9d6 · 044f9d6
1 parent 4a2ff7f
commit 044f9d6
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -148,7 +148,7 @@ jobs:
       - name: Use Deno
         uses: denoland/setup-deno@v1
         with:
-          deno-version: v1.26.1
+          deno-version: v1.34.1
 
       - name: Install dependencies
         run: pnpm install

diff --git a/packages/integrations/deno/test/basics.test.ts b/packages/integrations/deno/test/basics.test.ts
@@ -103,7 +103,13 @@ Deno.test({
 			const h1 = doc!.querySelector('h1');
 			assertEquals(h1!.innerText, 'test');
 		});
-
+
+		await t.step('node compatibility', async () => {
+		    const resp = await fetch(new URL('/nodecompat', app.url));
+			assertEquals(resp.status, 200);
+			await resp.text()
+		})
+
 		app.stop();
 	},
 });
diff --git a/packages/integrations/deno/test/fixtures/basics/package.json b/packages/integrations/deno/test/fixtures/basics/package.json
@@ -8,6 +8,7 @@
     "@astrojs/react": "workspace:*",
     "@astrojs/mdx": "workspace:*",
     "react": "^18.1.0",
-    "react-dom": "^18.1.0"
+    "react-dom": "^18.1.0",
+    "node-fetch": "3.3.1"
   }
 }
diff --git a/packages/integrations/deno/test/fixtures/basics/src/pages/index.astro b/packages/integrations/deno/test/fixtures/basics/src/pages/index.astro
@@ -1,7 +1,5 @@
 ---
 import ReactComponent from '../components/React.jsx';
-import fs from 'node:fs';
-fs.readFile('xyz')
 const envValue = import.meta.env.SOME_VARIABLE;
 ---
 <html>

diff --git a/packages/integrations/deno/test/fixtures/basics/src/pages/nodecompat.astro b/packages/integrations/deno/test/fixtures/basics/src/pages/nodecompat.astro
@@ -0,0 +1,21 @@
+---
+// node-fetch is implemented using node built-in module 'streams'
+import fetch from 'node-fetch'
+
+// unprefixed node built-in module
+import path from 'path'
+
+// prefixed node built-in module
+import os from 'node:os'
+
+const response = await fetch('https://api.github.com/users/github')
+const data = await response.json()
+---
+<body>
+<a href={path.posix.basename('/public/myfile.html')}>Go to my file</a>
+<details>
+    <summary>CPU Architecture</summary>
+    <code>{os.arch()}</code>
+</details>
+<p>Everything went fine.</p>
+</body>
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml