Skip to content

Commit

Permalink
Fix getViteConfig() type definition (#11046)
Browse files Browse the repository at this point in the history
  • Loading branch information
HiDeoo committed May 15, 2024
1 parent e90c98f commit 086694a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/popular-colts-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Fixes `getViteConfig()` type definition to allow passing an inline Astro configuration as second argument
6 changes: 5 additions & 1 deletion packages/astro/config.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
type ViteUserConfig = import('vite').UserConfig;
type ViteUserConfigFn = import('vite').UserConfigFn;
type AstroUserConfig = import('./dist/@types/astro.js').AstroUserConfig;
type AstroInlineConfig = import('./dist/@types/astro.js').AstroInlineConfig;
type ImageServiceConfig = import('./dist/@types/astro.js').ImageServiceConfig;
type SharpImageServiceConfig = import('./dist/assets/services/sharp.js').SharpImageServiceConfig;

Expand All @@ -13,7 +14,10 @@ export function defineConfig(config: AstroUserConfig): AstroUserConfig;
/**
* Use Astro to generate a fully resolved Vite config
*/
export function getViteConfig(config: ViteUserConfig): ViteUserConfigFn;
export function getViteConfig(
config: ViteUserConfig,
inlineAstroConfig?: AstroInlineConfig
): ViteUserConfigFn;

/**
* Return the configuration needed to use the Sharp-based image service
Expand Down

0 comments on commit 086694a

Please sign in to comment.