Skip to content

Commit

Permalink
chore: remove unecessary MagicString
Browse files Browse the repository at this point in the history
  • Loading branch information
bholmesdev committed Apr 11, 2023
1 parent 5e5a50c commit 1d16001
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 19 deletions.
7 changes: 1 addition & 6 deletions packages/astro/src/content/vite-plugin-content-assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
STYLES_PLACEHOLDER,
} from './consts.js';
import { getContentEntryExts } from './utils.js';
import MagicString from 'magic-string';

function isPropagatedAsset(viteId: string) {
const flags = new URLSearchParams(viteId.split('?')[1]);
Expand Down Expand Up @@ -84,11 +83,7 @@ export function astroContentAssetPropagationPlugin({
export const collectedScripts = ${stringifiedScripts};
`;

if (settings.config.vite.build?.sourcemap) {
const s = new MagicString(code);
return { code: s.toString(), map: s.generateMap() };
}
return code;
return { code, map: { mappings: '' } };
}
},
};
Expand Down
7 changes: 1 addition & 6 deletions packages/astro/src/content/vite-plugin-content-imports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { AstroErrorData } from '../core/errors/errors-data.js';
import { AstroError } from '../core/errors/errors.js';
import { escapeViteEnvReferences, getFileInfo } from '../vite-plugin-utils/index.js';
import { CONTENT_FLAG } from './consts.js';
import MagicString from 'magic-string';
import {
getContentEntryExts,
getContentPaths,
Expand Down Expand Up @@ -85,11 +84,7 @@ export function astroContentImportPlugin({
rawData: ${JSON.stringify(_internal.rawData)},
};`);

if (settings.config.vite.build?.sourcemap) {
const s = new MagicString(code);
return { code: s.toString(), map: s.generateMap() };
}
return code;
return { code, map: { mappings: '' } };
}
},
configureServer(viteServer) {
Expand Down
8 changes: 1 addition & 7 deletions packages/integrations/mdx/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import MagicString from 'magic-string';
import { markdownConfigDefaults } from '@astrojs/markdown-remark';
import { toRemarkInitializeAstroData } from '@astrojs/markdown-remark/dist/internal.js';
import { compile as mdxCompile } from '@mdx-js/mdx';
Expand Down Expand Up @@ -173,12 +172,7 @@ export default function mdx(partialMdxOptions: Partial<MdxOptions> = {}): AstroI
import.meta.hot.decline();
}`;
}
code = escapeViteEnvReferences(code);
if (config.vite.build?.sourcemap) {
const s = new MagicString(code);
return { code: s.toString(), map: s.generateMap() };
}
return code;
return { code: escapeViteEnvReferences(code), map: null };
},
},
] as VitePlugin[],
Expand Down

0 comments on commit 1d16001

Please sign in to comment.