Support strict dependency install for image integration (#5034)

withastro · Oct 10, 2022 · 2d9d422 · 2d9d422
1 parent 19a7688
commit 2d9d422
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/.changeset/small-laws-dream.md b/.changeset/small-laws-dream.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/image': patch
+---
+
+Support strict dependency install
diff --git a/packages/integrations/image/package.json b/packages/integrations/image/package.json
@@ -45,6 +45,7 @@
     "@altano/tiny-async-pool": "^1.0.2",
     "http-cache-semantics": "^4.1.0",
     "image-size": "^1.0.2",
+    "kleur": "^4.1.5",
     "magic-string": "^0.25.9",
     "mime": "^3.0.0",
     "slash": "^4.0.0"
@@ -57,7 +58,6 @@
     "astro-scripts": "workspace:*",
     "chai": "^4.3.6",
     "cheerio": "^1.0.0-rc.11",
-    "kleur": "^4.1.4",
     "mocha": "^9.2.2",
     "rollup-plugin-copy": "^3.4.0",
     "sharp": "^0.31.0",

diff --git a/packages/integrations/image/src/index.ts b/packages/integrations/image/src/index.ts
@@ -49,16 +49,15 @@ export default function integration(options: IntegrationOptions = {}): AstroInte
 	function getViteConfiguration() {
 		return {
 			plugins: [createPlugin(_config, resolvedOptions)],
-			optimizeDeps: {
-				include: ['image-size'].filter(Boolean),
-			},
 			build: {
 				rollupOptions: {
 					external: ['sharp'],
 				},
 			},
 			ssr: {
 				noExternal: ['@astrojs/image', resolvedOptions.serviceEntryPoint],
+				// CJS dependencies used by `serviceEntryPoint`
+				external: ['http-cache-semantics', 'image-size', 'mime'],
 			},
 			assetsInclude: ['**/*.wasm'],
 		};

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml