feedback

.changeset/pink-ligers-share.md

@@ -14,8 +14,7 @@ export default defineConfig({
 })
 ```
 
-When enabled, you can use `rewrite()` to **render
-** another page without changing the URL of the browser in Astro pages and endpoints.
+When enabled, you can use `rewrite()` to **render** another page without changing the URL of the browser in Astro pages and endpoints.
 
 ```astro
 ---
@@ -47,5 +46,4 @@ export function onRequest(ctx, next) {
 }
 ```
 
-> **NOTE
-**: please [read the RFC](https://github.com/withastro/roadmap/blob/feat/reroute/proposals/0047-rerouting.md) to understand the current expectations of the new APIs.
+> **NOTE**: please [read the RFC](https://github.com/withastro/roadmap/blob/feat/reroute/proposals/0047-rerouting.md) to understand the current expectations of the new APIs.

packages/astro/src/@types/astro.ts

@@ -1944,7 +1944,7 @@ export interface AstroUserConfig {
 		 * @version 4.8.0
 		 * @description
 		 *
-		 * Enables a routing feature for rewriting requests in Astro pages, endpoints and Astro middleware, giving you programmatic control over your routes. 
+		 * Enables a routing feature for rewriting requests in Astro pages, endpoints and Astro middleware, giving you programmatic control over your routes.
 		 *
 		 * ```js
 		 * {
@@ -1966,7 +1966,7 @@ export interface AstroUserConfig {
 		 * ```
 		 *
 		 * Use `context.rewrite` in your endpoint files to reroute to a different page:
-		 * 
+		 *
 		 * ```js
 		 * // src/pages/api.js
 		 * export function GET(ctx) {
@@ -1977,7 +1977,7 @@ export interface AstroUserConfig {
 		 * ```
 		 *
 		 * Use `next("/")` in your middleware file to reroute to a different page, and then call the next middleware function:
-		 * 
+		 *
 		 * ```js
 		 * // src/middleware.js
 		 * export function onRequest(ctx, next) {
@@ -1987,7 +1987,7 @@ export interface AstroUserConfig {
 		 * 	return next();
 		 * }
 		 * ```
-		 * 
+		 *
 		 * For a complete overview, and to give feedback on this experimental API, see the [Rerouting RFC](https://github.com/withastro/roadmap/blob/feat/reroute/proposals/0047-rerouting.md).
 		 */
 		rewriting: boolean;

packages/astro/src/core/app/pipeline.ts

@@ -86,11 +86,9 @@ export class AppPipeline extends Pipeline {
 					foundRoute = route;
 					break;
 				}
-			} else {
-				if (route.pattern.test(decodeURI(payload))) {
-					foundRoute = route;
-					break;
-				}
+			} else if (route.pattern.test(decodeURI(payload))) {
+				foundRoute = route;
+				break;
 			}
 		}
 
@@ -122,9 +120,9 @@ export class AppPipeline extends Pipeline {
 				return await importComponentInstance();
 			} else if (this.manifest.pageModule) {
 				return this.manifest.pageModule;
-			throw new Error(
-				"Astro couldn't find the correct page to render, probably because it wasn't correctly mapped for SSR usage. This is an internal error, please file an issue."
-			);
+				throw new Error(
+					"Astro couldn't find the correct page to render, probably because it wasn't correctly mapped for SSR usage. This is an internal error, please file an issue."
+				);
 			}
 		}
 	}

packages/astro/src/core/build/pipeline.ts

@@ -33,6 +33,8 @@ import type { PageBuildData, SinglePageBuiltModule, StaticBuildOptions } from '.
 import { i18nHasFallback } from './util.js';
 import { RedirectSinglePageBuiltModule } from '../redirects/index.js';
 import { getOutDirWithinCwd } from './common.js';
+import { RouteNotFound } from '../errors/errors-data.js';
+import { AstroError } from '../errors/index.js';
 
 /**
  * The build pipeline is responsible to gather the files emitted by the SSR build and generate the pages by executing these files.
@@ -288,18 +290,16 @@ export class BuildPipeline extends Pipeline {
 					foundRoute = route;
 					break;
 				}
-			} else {
-				if (route.pattern.test(decodeURI(payload))) {
-					foundRoute = route;
-					break;
-				}
+			} else if (route.pattern.test(decodeURI(payload))) {
+				foundRoute = route;
+				break;
 			}
 		}
 		if (foundRoute) {
 			const componentInstance = await this.getComponentByRoute(foundRoute);
 			return [foundRoute, componentInstance];
 		} else {
-			throw new Error('Route not found');
+			throw new AstroError(RouteNotFound);
 		}
 	}
 

packages/astro/src/core/errors/errors-data.ts

@@ -1483,6 +1483,18 @@ export const UnsupportedConfigTransformError = {
 	hint: 'See the devalue library for all supported types: https://github.com/rich-harris/devalue',
 } satisfies ErrorData;
 
+/**
+ * @docs
+ * @description
+ *
+ * Astro couldn't find a route matching the one provided by the user
+ */
+export const RouteNotFound = {
+	name: 'RouteNotFound',
+	title: 'Route not found.',
+	message: `Astro could find a route that matches the one you requested.`,
+} satisfies ErrorData;
+
 // Generic catch-all - Only use this in extreme cases, like if there was a cosmic ray bit flip.
 export const UnknownError = { name: 'UnknownError', title: 'Unknown Error.' } satisfies ErrorData;
 

packages/astro/src/core/render-context.ts

@@ -108,7 +108,8 @@ export class RenderContext {
 			return new Response('Loop Detected', {
 				// https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/508
 				status: 508,
-				statusText: 'Astro detected a loop where you tried to call the rewriting logic more than four times.',
+				statusText:
+					'Astro detected a loop where you tried to call the rewriting logic more than four times.',
 			});
 		}
 		const lastNext = async (ctx: APIContext, payload?: RewritePayload) => {

packages/astro/src/vite-plugin-astro-server/pipeline.ts

@@ -14,7 +14,7 @@ import { getInfoOutput } from '../cli/info/index.js';
 import type { HeadElements } from '../core/base-pipeline.js';
 import { ASTRO_VERSION, DEFAULT_404_COMPONENT } from '../core/constants.js';
 import { enhanceViteSSRError } from '../core/errors/dev/index.js';
-import { AggregateError, CSSError, MarkdownError } from '../core/errors/index.js';
+import { AggregateError, AstroError, CSSError, MarkdownError } from '../core/errors/index.js';
 import type { Logger } from '../core/logger/core.js';
 import type { ModuleLoader } from '../core/module-loader/index.js';
 import { loadRenderer, Pipeline } from '../core/render/index.js';
@@ -25,6 +25,7 @@ import { getComponentMetadata } from './metadata.js';
 import { createResolve } from './resolve.js';
 import { default404Page } from './response.js';
 import { getScriptsForURL } from './scripts.js';
+import { RouteNotFound } from '../core/errors/errors-data.js';
 
 export class DevPipeline extends Pipeline {
 	// renderers are loaded on every request,
@@ -208,19 +209,17 @@ export class DevPipeline extends Pipeline {
 					foundRoute = route;
 					break;
 				}
-			} else {
-				if (route.pattern.test(decodeURI(payload))) {
-					foundRoute = route;
-					break;
-				}
+			} else if (route.pattern.test(decodeURI(payload))) {
+				foundRoute = route;
+				break;
 			}
 		}
 
 		if (foundRoute) {
 			const componentInstance = await this.getComponentByRoute(foundRoute);
 			return [foundRoute, componentInstance];
 		} else {
-			throw new Error('Route not found');
+			throw new AstroError(RouteNotFound);
 		}
 	}