Apply suggestions from code review

withastro · Feb 29, 2024 · b818e2f · b818e2f
1 parent 302d6b9
commit b818e2f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/astro/src/core/request.ts b/packages/astro/src/core/request.ts
@@ -47,8 +47,10 @@ export function createRequest({
 
 	if (typeof url === 'string') url = new URL(url);
 
+	const imageEndpoint = prependForwardSlash(appendForwardSlash(base)) + '_image';
+
 	// HACK! astro:assets uses query params for the injected route in `dev`
-	if (staticLike && url.pathname !== `${prependForwardSlash(appendForwardSlash(base))}_image`) {
+	if (staticLike && url.pathname !== imageEndpoint) {
 		url.search = '';
 	}
 

diff --git a/packages/astro/src/vite-plugin-astro-server/route.ts b/packages/astro/src/vite-plugin-astro-server/route.ts
@@ -227,7 +227,7 @@ export async function handleRoute({
 			body,
 			logger,
 			clientAddress: incomingRequest.socket.remoteAddress,
-			staticLike: config.output === "static" ? true : route.prerender,
+			staticLike: config.output === "static" || route.prerender,
 		});
 
 		// Set user specified headers to response object.