Fix types for TableHTMLAttributes (#6197)

* Fix types for TableHTMLAttributes - Add 'string' type to 'border' attribute - Add 'false | true' to 'frame' attribute Thanks Princesseuh for helping * Create sixty-scissors-refuse.md * Make changeset more descriptive * Fix previous changset --------- Co-authored-by: BryceRussell <19967622+BryceRussell@users.noreply.github.com>
withastro · Feb 9, 2023 · c75d319 · c75d319
1 parent 11e1fa9
commit c75d319
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/sixty-scissors-refuse.md b/.changeset/sixty-scissors-refuse.md
@@ -0,0 +1,6 @@
+---
+'astro': patch
+---
+
+Fix `border` and `frame` attribute types on `TableHTMLAttributes` interface
+
diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts
@@ -936,10 +936,10 @@ declare namespace astroHTML.JSX {
 	interface TableHTMLAttributes extends HTMLAttributes {
 		align?: 'left' | 'center' | 'right' | undefined | null;
 		bgcolor?: string | undefined | null;
-		border?: number | undefined | null;
+		border?: string | number | undefined | null;
 		cellpadding?: number | string | undefined | null;
 		cellspacing?: number | string | undefined | null;
-		frame?: boolean | undefined | null;
+		frame?: boolean | 'false' | 'true' | undefined | null;
 		rules?: 'none' | 'groups' | 'rows' | 'columns' | 'all' | undefined | null;
 		summary?: string | undefined | null;
 		width?: number | string | undefined | null;