fix(audit): mark widget roles as interactive (#9825)

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
withastro · Jan 26, 2024 · e4370e9 · e4370e9
1 parent a3df9d8
commit e4370e9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 28 deletions.
diff --git a/.changeset/old-actors-taste.md b/.changeset/old-actors-taste.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes false positive aria role errors on interactive elements
diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts
@@ -50,11 +50,8 @@ const aria_non_interactive_roles = [
 	'application',
 	'article',
 	'banner',
-	'button',
 	'cell',
-	'checkbox',
 	'columnheader',
-	'combobox',
 	'complementary',
 	'contentinfo',
 	'definition',
@@ -64,55 +61,30 @@ const aria_non_interactive_roles = [
 	'feed',
 	'figure',
 	'form',
-	'grid',
-	'gridcell',
 	'group',
 	'heading',
 	'img',
-	'link',
 	'list',
-	'listbox',
 	'listitem',
 	'log',
 	'main',
 	'marquee',
 	'math',
-	'menu',
-	'menubar',
-	'menuitem',
-	'menuitemcheckbox',
 	'menuitemradio',
 	'navigation',
 	'none',
 	'note',
-	'option',
 	'presentation',
-	'progressbar',
-	'radio',
-	'radiogroup',
 	'region',
 	'row',
 	'rowgroup',
 	'rowheader',
-	'scrollbar',
 	'search',
-	'searchbox',
-	'separator',
-	'slider',
-	'spinbutton',
 	'status',
-	'switch',
-	'tab',
-	'tablist',
-	'tabpanel',
 	'term',
-	'textbox',
 	'timer',
 	'toolbar',
 	'tooltip',
-	'tree',
-	'treegrid',
-	'treeitem',
 ];
 
 const a11y_required_content = [