Fix asset loading in dev mode (#6466)

* Fix asset loading in dev mode * Proper windows support
withastro · Mar 8, 2023 · ec04553 · ec04553
1 parent 401b97a
commit ec04553
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/.changeset/red-candles-retire.md b/.changeset/red-candles-retire.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+In dev, load assets relative to the root
diff --git a/packages/astro/src/assets/vite-plugin-assets.ts b/packages/astro/src/assets/vite-plugin-assets.ts
@@ -78,8 +78,8 @@ export default function assets({
 							return next();
 						}
 
-						const filePathURL = new URL(filePath, 'file:');
-						const file = await fs.readFile(filePathURL.pathname);
+						const filePathURL = new URL('.' + filePath, settings.config.root);
+						const file = await fs.readFile(filePathURL);
 
 						// Get the file's metadata from the URL
 						let meta = getOrigQueryParams(filePathURL.searchParams);
@@ -109,7 +109,7 @@ export default function assets({
 							format = result.format;
 						}
 
-						res.setHeader('Content-Type', mime.getType(fileURLToPath(url)) || `image/${format}`);
+						res.setHeader('Content-Type', mime.getType(fileURLToPath(filePathURL)) || `image/${format}`);
 						res.setHeader('Cache-Control', 'max-age=360000');
 
 						const stream = Readable.from(data);

diff --git a/packages/astro/test/core-image.test.js b/packages/astro/test/core-image.test.js
@@ -72,6 +72,13 @@ describe('astro:image', () => {
 				expect($img.attr('alt')).to.equal('a penguin');
 			});
 
+			it('middleware loads the file', async() => {
+				let $img = $('#local img');
+				let src = $img.attr('src');
+				let res = await fixture.fetch(src);
+				expect(res.status).to.equal(200);
+			});
+
 			it('errors on unsupported formats', async () => {
 				logs.length = 0;
 				let res = await fixture.fetch('/unsupported-format');