Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Rollback Nodejs Dependancy #3908

Closed
1 task done
ran-dall opened this issue Jul 12, 2022 · 4 comments · Fixed by #3914
Closed
1 task done

🐛 BUG: Rollback Nodejs Dependancy #3908

ran-dall opened this issue Jul 12, 2022 · 4 comments · Fixed by #3914

Comments

@ran-dall
Copy link
Contributor

ran-dall commented Jul 12, 2022

What version of astro are you using?

astro@1.0.0-beta.69

Are you using an SSR adapter? If so, which one?

N/A

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

I've been manning support threads today, and during troubleshooting, I found out that astro@1.0.0-beta.69 depends on node: '^14.20.0 || >=16.16.0, however the issue with that there are many distros that haven't stabilized 16.16.0, including Red Hat, Microsoft (both CBL Marinier and VSCode's Devcontainer images), Debian (which is probably the most important one), and Gentoo (had to give Gentoo a plug).

I've been advised by both Red Hat and MS's VSCode teams that the best solution would be to downgrade our Nodejs dependency to 16.15.1 (or even 16.14.0, as it's the most consistent and stable across distros).

Debian Ref: https://packages.debian.org/sid/nodejs
Gentoo Ref: https://packages.gentoo.org/packages/net-libs/nodejs
Red Hat Ref: https://access.redhat.com/downloads/content/nodejs/16.14.0-4.module+el8.6.0+15294+54b291d2/x86_64/fd431d51/package (it may require employee or customer access, so I attached a screenshot)
image

FWIW: Arch DOES have 16.16.0 in the gallium branch, and Homebrew does have 16.16.0 as node@16, but it seems no one else does.

ping @matthewp @aFuzzyBear

Link to Minimal Reproducible Example

N/A

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added this to Needs Triage in 🐛 Bug Tracker Jul 12, 2022
@ran-dall
Copy link
Contributor Author

ran-dall commented Jul 13, 2022

FWIW This break VSCode Devcontainers and GitHub CodeSpaces, as both use dpkg packages on their official images (both share images, I'm almost sure).

@matthewp
Copy link
Contributor

This was changed in #3871

Not sure what to do here, @natemoo-re has more context on why this was changed. If we have to choose between an astro add bug or not having Astro work in CodeSpaces, etc. I think we probably have to accept the astro add bug, but maybe there's another way.

@ran-dall
Copy link
Contributor Author

ran-dall commented Jul 13, 2022

@matthewp To be clear, though, this makes Astro break on (most) all Linux-based modes of operation. I can't even run it on my Gentoo (which is supposed to be pretty progressive), as Gentoo doesn't even have 16.16.0 uploaded for testing. (I'll make an ebuild today for it, though)

To give you an idea of the significance of that, Gentoo (distro differ) has a 30-90 day stabilization period before stabilizing a new package version. This is worth considering since most distros don't even have 16.16.0 in for testing (not just Gentoo, but Debian is a big one, for instance), so it might be a few months+ until we see 16.16.0 stabilized across Linux.

@ran-dall
Copy link
Contributor Author

ran-dall commented Jul 13, 2022

I made a PR in Gentoo for Node 16.16.0 (gentoo/gentoo#26384). I already have PR open with Red Hat for rpm. I'm going to try to get in touch with someone who has authority in the deb ecosystem and see if I can push that along too.

ran-dall added a commit to ran-dall/astro that referenced this issue Jul 13, 2022
Closes withastro#3908

Signed-off-by: Randall T. Vasquez <ran.dall@icloud.com>
ran-dall added a commit to ran-dall/astro that referenced this issue Jul 13, 2022
Closes withastro#3908

Signed-off-by: Randall T. Vasquez <ran.dall@icloud.com>
🐛 Bug Tracker automation moved this from Needs Triage to Done Jul 13, 2022
matthewp pushed a commit that referenced this issue Jul 13, 2022
* Rollback Nodejs Dependancy

Closes #3908

Signed-off-by: Randall T. Vasquez <ran.dall@icloud.com>

* Create ninety-apes-talk.md
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this issue Feb 3, 2023
* Rollback Nodejs Dependancy

Closes withastro#3908

Signed-off-by: Randall T. Vasquez <ran.dall@icloud.com>

* Create ninety-apes-talk.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants