Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client directive not working on namespaced JSX #4389

Closed
1 task
pomber opened this issue Aug 19, 2022 · 8 comments
Closed
1 task

Client directive not working on namespaced JSX #4389

pomber opened this issue Aug 19, 2022 · 8 comments
Labels
- P2: has workaround Bug, but has workaround (priority)

Comments

@pomber
Copy link

pomber commented Aug 19, 2022

What version of astro are you using?

1.0.6

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm, yarn

What operating system are you using?

Linux

Describe the Bug

This is hydrated

import { Counter } from '../components/Counter.jsx';

<Counter client:load />

but this isn't

import { Foo } from '../components/Foo.jsx';

<Foo.Counter client:load />

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-stiwfz-adqbjh?file=package.json

Participation

  • I am willing to submit a pull request for this issue.
@pomber
Copy link
Author

pomber commented Aug 19, 2022

Hey @natemoo-re, sorry to reopen issue #4209, but looks like it is still happening.

@pomber
Copy link
Author

pomber commented Aug 22, 2022

To add more context, I think this is the only issue blocking the integration of Astro with Code Hike.

@peterkrieg
Copy link

peterkrieg commented Sep 1, 2022

Thanks @pomber for your excellent work with code hike, it looks amazing! I'm looking forward to trying it on astro, it feels like a really good fit for a content-focused framework like astro.

I saw this has the p2-has-workaround tag but I haven't seen a workaround yet. @FredKSchott are you aware of one? Thanks in advance for any help

@natemoo-re natemoo-re removed their assignment Sep 6, 2022
@JohnDaly
Copy link
Contributor

This issue should be fixed by: #4403

The latest version of Astro should support this use case

@pomber
Copy link
Author

pomber commented Sep 19, 2022

@JohnDaly do you know what's wrong with this example?

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-stiwfz-adqbjh?file=package.json

@JohnDaly
Copy link
Contributor

@JohnDaly do you know what's wrong with this example?

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-stiwfz-adqbjh?file=package.json

Updating that example to use "astro": "^1.2.6" should fix the problem

@rishi-raj-jain
Copy link
Contributor

rishi-raj-jain commented Sep 24, 2022

@matthewp this can be closed per comment above ig.

here's the same upgraded to the latest version that works https://stackblitz.com/edit/github-stiwfz-pzfnv2?file=src%2Fpages%2Findex.mdx

@matthewp
Copy link
Contributor

matthewp commented Oct 7, 2022

Great, thank you everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: has workaround Bug, but has workaround (priority)
Projects
None yet
Development

No branches or pull requests

7 participants