Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning with @astrojs/vercel/serverless due to Dependency Resolution and Eval Issues #7654

Closed
1 task
jacobdalamb opened this issue Jul 14, 2023 · 4 comments · Fixed by #7659
Closed
1 task
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)

Comments

@jacobdalamb
Copy link
Contributor

jacobdalamb commented Jul 14, 2023

What version of astro are you using?

2.8.3

Are you using an SSR adapter? If so, which one?

Vercel

What package manager are you using?

pnpm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

When using the @astrojs/vercel/serverless integration and running pnpm build, the build completes successfully but multiple warnings appear regarding dependency resolution and use of eval in binary-locators.js.

What's the expected result?

The build completes successfully without any warnings with the @astrojs/vercel/serverless integration.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-jq9nj3?file=package.json

Participation

  • I am willing to submit a pull request for this issue.
@natemoo-re natemoo-re added the - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Jul 14, 2023
@natemoo-re
Copy link
Member

Yikes, thank you for the report! I'm not sure where these dependencies are coming from, to be honest... they may have slipped into our @astrojs/vercel/serverless code in a recent update? These definitely don't look like things that should be bundled with our runtime at all.

cc @ematipico

@natemoo-re
Copy link
Member

Given that Ema is off for the weekend but this is a P5, I'm going to look into this now.

@natemoo-re natemoo-re assigned natemoo-re and unassigned ematipico Jul 14, 2023
@jacobdalamb jacobdalamb changed the title Build Fails with @astrojs/vercel/serverless due to Dependency Resolution and Eval Issues Build warning with @astrojs/vercel/serverless due to Dependency Resolution and Eval Issues Jul 14, 2023
@jacobdalamb
Copy link
Contributor Author

Yikes, thank you for the report! I'm not sure where these dependencies are coming from, to be honest... they may have slipped into our @astrojs/vercel/serverless code in a recent update? These definitely don't look like things that should be bundled with our runtime at all.

cc @ematipico

Sorry, the build doesn't fail but when I tried doing a preview deployment, it took a long time to build so I canceled it. This error showed up after updating to 3.6.0 of the integration.

@natemoo-re
Copy link
Member

No problem, I was able to get a quick fix. It was attempting to bundle an internal dependency that it shouldn't!

Hoping to get #7659 out quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants