☂️ Move Astro tests to node:test

[ematipico]

Description

Internally, the team decided to move our testing infrastructure to use node:test instead of Mocha.

While Mocha is good, it has its own quirks. Also, we believe that the Node.js test runner will improve with time.

This is an excellent opportunity to contribute to Astro and help us with the migration because you don't need to understand Astro logic. So if you have been looking for an opportunity to contribute to Astro, this is the perfect chance for you!

Plan

Comment here which integration/adapter you want to migrate first. Failing to comment might nullify your contribution if someone else did the work and commented on the issue. This will help us to avoid having multiple people working on the same thing.

The plan should be as follows:

1. Migrate tests of our @astrojs/* packages. This can be done in one PR, because we only have a few tests inside our integrations/adapters. You can use this PR as a blueprint of what we're looking for: chore(@astrojs/node): use Node.js for testing #9758
2. Progressively migrate the tests we have in core, starting with the unit tests, then integrations tests. This means that we need to have two scripts, one that will run the tests using Mocha, and one that will run the tests using Node.js

Integrations/adapters

List of the integrations/adapters

• Migrate tests of @astrojs/vue
• Migrate tests of @astrojs/alpinejs
• Migrate tests of @astrojs/lit @xMohamd
• Migrate tests of @astrojs/markdoc
• Migrate tests of @astrojs/mdx
• Migrate tests of @astrojs/partytown
• Migrate tests of @astrojs/preact
• Migrate tests of @astrojs/react
• Migrate tests of @astrojs/sitemap
• Migrate tests of @astrojs/solid
• Migrate tests of @astrojs/svelte
• Migrate tests of @astrojs/tailwind
• Migrate tests of @astrojs/vercel @mingjunlu

Core

• Migrate tests of @astrojs/rss
• Migrate tests of @astrojs/internal-helpers
• Migrate tests of telemetry @VoxelMC
• Migrate tests of @astrojs/underscore-redirects
• Migrate tests of @astrojs/upgrade

astro

After #10002 is merged, we can progressively start migrating tests.

Instructions:

• rename a *.test.js file to *.nodetest.js, e.g. api.test.js -> api.nodetest.js
• migrate the content of the test to use Node.js test runner
• use the command pnpm test:node to run only the files that use Node.js test runner

Warning

Node.js test runner doesn't handler deep nested describe, so it's possible your test could hang and timeout. If that happens, lift the describe function.

• Migrate tests of astro

External adapters

withastro/adapters#144

[log101]

Would love to contribute, I'd like to grab @astrojs/tailwind if that's OK?

[mingjunlu]

I would like to migrate tests of @astrojs/sitemap 🗺️

[VoxelMC]

I'll try first with telemetry!

I know it's a core package, but it is a small one, so I thought it could start some discussion about progressively migrating the tests!

[at-the-vr]

I will take a hit on @astrojs/vue

[alexnguyennz]

Working on @astrojs/mdx.

[ktym4a]

I will take @astrojs/markdoc.

[VoxelMC]

I will do @astrojs/react!
Does @astrojs/svelte have tests?

[ematipico]

I will do @astrojs/react!
Does @astrojs/svelte have tests?

It seems not, thank you for checking

[xMohamd]

I will do @astrojs/react!
Does @astrojs/svelte have tests?

It seems not, thank you for checking

I think also @astrojs/solid, @astrojs/preact, and @astrojs/partytown don't have tests

[VoxelMC]

Doing @astrojs/alpinejs now!
I may need some assistance for this, as it uses Playwright instead of Mocha. Either that, or someone else should take it!

[ematipico]

Doing @astrojs/alpinejs now!
I may need some assistance for this, as it uses Playwright instead of Mocha. Either that, or someone else should take it!

If there aren't any mocha tests, we can skip the package

[xMohamd]

I will try with @astrojs/lit later today

[VoxelMC]

Doing @astrojs/alpinejs now!
I may need some assistance for this, as it uses Playwright instead of Mocha. Either that, or someone else should take it!

If there aren't any mocha tests, we can skip the package

I will take on @astro/rss instead, then :)

[at-the-vr]

I will take a hit on @astrojs/underscore-redirects

[VoxelMC]

I can take the slots-* tests while I wait for confirmation on my next PR!

[at-the-vr]

I will take collection-collection-* tests

This one is a brainteaser, if someone else could do this that would be super helpful 🙏 (looking at ya Voxel 👀 )

[at-the-vr]

I will take the alias-**.test.js

[ematipico]

I'll take files that:

• starts with the letter d*
• starts with the letter e*

[ematipico]

I'll take files that:

• starts with v
• starts with u
• starts with s
• starts with t

[at-the-vr]

I will take css-* tests

[ematipico]

I'll take files that start with p* and r*

[ktym4a]

I'll take files that start with f*, g* and h*.

I made this files featuresSupport, fetch, fontsource in PR #10115

so I'll take files that start with g* and h*.

[marwan-mohamed12]

I made this files featuresSupport, fetch, fontsource in PR #10115

[ematipico]

I'll take files that start with m*, n* and l*

[ktym4a]

JUST MEMO

If my checks are correct, the remaining tests are these:

• start with 0* chore: move test to node #10134
• start with a* chore: migrate several tests to node:test #10133
• start with c* chore: move test to node #10134
• start with g* chore: move test to node #10125
• start with h* chore: move test to node #10125
• start with i* @ematipico chore: move tests that starts with i and j #10129
• start with j* @ematipico chore: move tests that starts with i and j #10129
• start with l* chore: move tests to node #10127
• start with m* chore: move tests to node #10127
• start with n* chore: move tests to node #10127
• start with p* chore: move tests to node #10123
• start with r* chore: move tests to node #10123

[ematipico]

I'll i* and j*

[ktym4a]

I'll take 0* and c*.

[mingjunlu]

I'll take a*