Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate alias tests to node:test #10108

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

at-the-vr
Copy link
Member

Changes

Testing

All tests passing. alias.nodetest.js seems to be skipped on local testing (probably because of isWindows util)

Docs

N/A

Copy link

changeset-bot bot commented Feb 14, 2024

⚠️ No Changeset found

Latest commit: 4d6ffe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 14, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM, I will merge it once the CI passes

@ematipico ematipico merged commit f7f2006 into withastro:main Feb 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants