Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finalize WIP API #10280

Merged
merged 90 commits into from Mar 2, 2024
Merged

finalize WIP API #10280

merged 90 commits into from Mar 2, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Move to unified defineTable() config
  • Move all logic to the db/ directory for config, seeding, and migrations
  • Remove all logic and test suites for "readable" tables
  • Temporary: remove "unsafe disable" flag for studio connections in prod builds

Testing

  • Update basics tests to be development-only. Should create a proxy server to mimic a remote connection for production builds.

Docs

They're coming, Sarah. They're coming.

@bholmesdev
feat: no more readable / writable
fbb9c50
@bholmesdev
fix: table typegen
448edc1
@bholmesdev
wip: move data seeding
cc23ba2
@bholmesdev
chore: add scripts to basics
607664f
@bholmesdev
feat: data() -> seed file
2299a9c
@bholmesdev
refactor: ensure precedence of file name
203dbe3
@bholmesdev
feat: db execute command
9c0139b
@bholmesdev
fix: test imports
cbc4dc5
@bholmesdev
chore: remove old readable error tests
6f0c5d3
@bholmesdev
feat: support local db with db execute
80154b4
@bholmesdev
refactor: remove integrations from test for now
8886b5c
@bholmesdev
chore: stray comment
56ea81d
@bholmesdev
chore: remove table config object
274504b
@bholmesdev
feat: db.batch!
0a3efac
@bholmesdev
refactor: move migrations/ inside db/
f170997
@bholmesdev
fix: move ticketing-example to seed file
a0cebe3
@bholmesdev
fix: disable foreign keys when recreating tables
30854cd
@bholmesdev
refactor: standardize migrations dir
fbc136e
@bholmesdev
feat: move to db/config.ts
783c22d
@bholmesdev
feat: file watching for db/config.ts dependencies
4f8e275
@bholmesdev
feat: remove unsafeDisableStudio
8936506
@bholmesdev
chroe: remove bad import
69277b9
@bholmesdev
feat: parse config.ts from cli
258a946
@bholmesdev
chore: remove async from localDatabaseClient
933c02f
@bholmesdev
fix: update recipes config and seed
1e5e235
@bholmesdev
chore: update unit tests
217d5bb
@bholmesdev
chore: update tests to dev server
25cb455
@bholmesdev
refactor: collectionToTable -> asDrizzleTable
0b9d963
@bholmesdev
chore: tidy up collection -> table error states
dc0af08
@bholmesdev
refactor: regexp -> endsWith
868beb5
FredKSchott
FredKSchott approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bholmesdev bholmesdev merged commit 3488be9 into main Mar 2, 2024
13 checks passed
@bholmesdev bholmesdev deleted the feat/phil-collins-closing-song branch March 2, 2024 00:29
@astrobot-houston astrobot-houston mentioned this pull request Mar 2, 2024
Merged
peng added a commit to peng/astro that referenced this pull request Mar 4, 2024
@peng
Merge branch 'main' into add-multiple-cdn-v2
ecd9414 
* main:
  [ci] format
  fix(withastro#8625): smooth scrolling in SPA mode on iOS (withastro#10235)
  [ci] release (withastro#10292)
  [ci] format
  finalize WIP API (withastro#10280)
  [ci] format
  fix(markdoc & mdx): Proxy crimes (withastro#10278)
  [ci] release (withastro#10286)
  fix(audits): Don't warn about loading on data URIs (withastro#10275)
  fix(node): Safely create requests (withastro#10285)
  [ci] release (withastro#10265)
  [ci] format
  fix(assets): Solidify Node endpoint (withastro#10284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bholmesdev @FredKSchott @natemoo-re