fix: fixed an error in the vue component editor #10293
Conversation
|
github-actions
bot
added
pkg: vue
|
@ematipico, I apologize for any inconvenience. Due to some unexpected issues, I accidentally closed this PR(#10283 ). I have since resubmitted it, and in doing so, all the issues have been resolved. I appreciate your understanding. |
|
Hi @ematipico! Could you please review the code again? If everything is fine, could you merge it? I would like to resolve this issue as soon as possible. |
|
@bluwy may I have a review from you too? |
bluwy
changed the title
There was a problem hiding this comment.
Left a couple comments and the idea seems fine, but I think @Princesseuh has better insights on the tooling side of changes 😅
| import { defineProps } from '@vue/runtime-core'; | ||
| import { defineProps } from 'vue'; |
There was a problem hiding this comment.
Is there a reason @vue/runtime-core is changed to vue. We should also remove the indent changes
There was a problem hiding this comment.
Would love to know this as well, I remember purposely using @vue/runtime-core instead of vue. IIRC it's not quite the same function. (though now I do wonder if this worked on pnpm since it's not a direct dep?)
There was a problem hiding this comment.
In my case with pnpm, I found that @vue/runtime-core might not be installed, In order to ensure the correct import of defineProps, I changed it to vue because it will be installed.
There was a problem hiding this comment.
Would love to know this as well, I remember purposely using
@vue/runtime-coreinstead ofvue. IIRC it's not quite the same function. (though now I do wonder if this worked onpnpmsince it's not a direct dep?)
I tested it with npm and pnpm, just as you thought, it's not directly dependent on pnpm.
bluwy
changed the title
* main: [ci] release (withastro#10337) Revert bad release (withastro#10336) [ci] release (withastro#10332) add missing changeset (withastro#10335) [ci] set `--tag` on release (withastro#10323) [ci] format add back data loss confirmation handling (withastro#10330) [ci] format fix(rendering): allow render instructions to propagate while rendering slots (withastro#10316) [ci] format fix: fixed an error in the vue component editor (withastro#10293) chore(vercel): update @vercel/nft (withastro#10305) Update turbo test dependsOn (withastro#10329) Add minimal @astrojs/db readme (withastro#10331)
fix withastro/language-tools#758
Changes