New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(astro): static entrypoints build with path with several '.astro' #10302
Merged
ematipico
merged 8 commits into
withastro:main
from
florian-lefebvre:fix/injectroute-entrypoint
Mar 4, 2024
Merged
fix(astro): static entrypoints build with path with several '.astro' #10302
ematipico
merged 8 commits into
withastro:main
from
florian-lefebvre:fix/injectroute-entrypoint
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2448f29 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Related to the core `astro` package (scope)
label
Mar 2, 2024
bluwy
reviewed
Mar 4, 2024
packages/astro/test/fixtures/integration-inject-route-entrypoint/package.json
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Mar 4, 2024
ematipico
reviewed
Mar 4, 2024
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
ematipico
approved these changes
Mar 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getVirtualModulePageNameFromPath
function.astro
Testing
Added a simple test that checks if the build passes.
Docs
Bug fix, N/A.