Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make 3rd party integration warning less scary #10496

Merged
merged 3 commits into from Apr 2, 2024

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Removes "Use at your own risk!" when using astro add with a 3rd party integration. It does not remove any check

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: be7b367

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 19, 2024
@ematipico
Copy link
Member

ematipico commented Mar 19, 2024

I believe that Use at your own risk! is a valid message, and it's not scary at all. Why would that be scary?

@florian-lefebvre
Copy link
Member Author

Scary may not be the term but this is following a discussion on discord with ben. See https://discord.com/channels/830184174198718474/1197638002764152843/1219466148567973918 for context

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! And to your comment @ematipico, I agree we should have a warning prompt before a user installs a third party integration. However, the addition of "Use at your own risk!" implies the user is doing something wrong by installing a third party integration. They are not! We have a large integration community, and we should keep the warning to just "This is not an official Astro integration. Continue?"

@Adammatthiesen
Copy link

We have a large integration community, and we should keep the warning to just "This is not an official Astro integration. Continue?"

100% agree, I personally kinda felt the "use at your own risk" meant your now "outside of the scope of the withAstro viewpoint" even if they were packages that could be common use among MANY of the community members (Expressive Code for example)

@matthewp matthewp merged commit ce98563 into main Apr 2, 2024
13 checks passed
@matthewp matthewp deleted the florian-lefebvre-patch-1 branch April 2, 2024 17:52
@astrobot-houston astrobot-houston mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants