Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Type error on <Image /> component when strict TypeScript rules are used with library type checking. #10549

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Fix: Type error on <Image /> component when strict TypeScript rules are used with library type checking. #10549

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
825523f
hotfix:ts-explicit-error
admirsaheta Mar 25, 2024
e4f90ac
add:changeset
admirsaheta Mar 25, 2024
db65e07
update:changeset
admirsaheta Mar 25, 2024
0a0aebd
Update .changeset/blue-dolls-melt.md
admirsaheta Mar 25, 2024
9b5fd0e
add:types-htmlattribute-extends
admirsaheta Mar 25, 2024
cb010b6
Merge branch 'main' of github.com:admirsaheta/astro
admirsaheta Mar 25, 2024
093c947
Update .changeset/blue-dolls-melt.md
admirsaheta Mar 25, 2024
d155de7
Merge branch 'main' into main
admirsaheta Mar 25, 2024
c663f20
Update blue-dolls-melt.md
florian-lefebvre Mar 25, 2024
e2f956b
addition: allow specifying null type
admirsaheta Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blue-dolls-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Updated the `HTMLAttributes` type exported from `astro` to allow data attributes
7 changes: 5 additions & 2 deletions packages/astro/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@ import type { Simplify } from './dist/type-utils.js';

/** Any supported HTML or SVG element name, as defined by the HTML specification */
export type HTMLTag = keyof astroHTML.JSX.DefinedIntrinsicElements;

/** The built-in attributes for any known HTML or SVG element name */
export type HTMLAttributes<Tag extends HTMLTag> = Omit<
astroHTML.JSX.IntrinsicElements[Tag],
keyof Omit<AstroBuiltinAttributes, 'class:list'>
>;
keyof Omit<AstroBuiltinAttributes, 'class:list'>
> & {
[key: string]: string | number | boolean | undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Princesseuh Do you prefer any?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without necessarily using any, allowing also null would be great

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without necessarily using any, allowing also null would be great

Done

};

/**
* All the CSS properties available, as defined by the CSS specification
Expand Down