Patch for Astro VS Code Plugin type errors #10562
Conversation
Adding 'as any' to suppress Astro VS Code extension complaining
🦋 Changeset detectedLatest commit: bf1c583 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Thank you for contributing! I think the cast here are actually unsafe, and this PR has some overlap with #10561. I'll commit just a few small changes, and we'll get it merged. |
| @@ -89,7 +89,7 @@ const highlighter = await getCachedHighlighter({ | |||
|
|
|||
| const html = highlighter.highlight(code, typeof lang === 'string' ? lang : lang.name, { | |||
| inline, | |||
There was a problem hiding this comment.
For reviewers, those cast look suspicious, but there's actually already a bunch of said casts in the file. I don't really know why, perhaps @bluwy has more context having worked on Shiki recently?
There was a problem hiding this comment.
Okay, not sure what happened, GitHub moved my comment.. but I'm talking about the as any casts on lang.
Changes
Closes #10560
Suggestive changes to typing that seems to silence the errors generated by the Astro VS Code plugin in a fresh project setup with the
/examples/framework-reactexample as outlined in #10560Testing
Tested in project, type annotation changes only
Docs
N/A