fix(types): Omit data types from polymorphic attributes #10593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I tried finding a proper fix to this, but I kinda don't understand the underlying issue. It seems like all the type merging, the Omits etc are really confusing to TS and it gives up. Optimally,
HTMLAttributes
should most likely work differently, and not actually omit attributes specific to Astro, but that'd be a breaking change to do now. So for now, this just reverts things to the way they were before and things work.Fixes #10577
Testing
Tested manually
Docs
N/A