Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sharp libvips cache. #10616

Merged

Conversation

NikolaRHristov
Copy link
Contributor

So, we were able fix a lot of our errors in CompressAstro with sharp namely:

generating optimized images
--
09:09:54.680 | free(): invalid size
09:14:20.856 | Error: Command "npm run build" exited with SIGABRT

and:

munmap_chunk(): invalid pointer

in these issues:

PlayForm/Compress#319
PlayForm/Compress#280

through:

PlayForm/Compress#319 (comment)

and:

PlayForm/Compress#280 (comment)

This PR disables the sharp libvips cache, as it errors when the file is too small and operations are happening too fast (runs into a race condition) - lovell/sharp#3935 (comment)

Copy link

changeset-bot bot commented Mar 30, 2024

🦋 Changeset detected

Latest commit: ab0ef29

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 30, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that explains the new line of code?

Having a comment that explains this cache issue would give us a lot of context. Is there - also - an issue you can add to said comment?

One more thing, you'll need to add a changeset :)

Thank you!

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, wonky but it happens.

@Princesseuh Princesseuh merged commit 317d18e into withastro:main Apr 3, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 3, 2024
@NikolaRHristov NikolaRHristov deleted the disable-sharp-libvips-cache branch April 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants