Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svelte): update import statements and bump peer dependency for v5 #10645

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix(svelte): update import statements and bump peer dependency for v5 #10645

merged 3 commits into from
Apr 2, 2024

Conversation

mingjunlu
Copy link
Contributor

Changes

Testing

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: be367f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Apr 2, 2024
@mingjunlu mingjunlu force-pushed the fix/svelte-5-private-module-error branch from d4fd5b9 to b84abcf Compare April 2, 2024 13:00
bluwy
bluwy approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bluwy bluwy merged commit 51112ab into withastro:main Apr 2, 2024
4 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 2, 2024
Merged
@mingjunlu mingjunlu deleted the fix/svelte-5-private-module-error branch April 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Svelte integration with Svelte 5 is unusable since svelte@5.0.0-next.88
2 participants
@mingjunlu @bluwy