-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable allowJs
for strictest.json
#10762
Conversation
🦋 Changeset detectedLatest commit: 9995749 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
!preview js-strictest |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, probably won't break too many people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changeset here, just suggesting that we add the helpful tip from the blog post here in the changeset too, for your consideration!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
Resolves #10507
This allows typechecking for JS files when using the
strictest
TS config. This is consistent with our other TS configs, and fixes virtual module types provided by integrations like Astro DB (#10507)Testing
Docs