Prevents inputs from changing ViewTransitions' form method or action

[robertvanhoesel]

Changes

Fixes #10849. Prevents inputs with a name attribute of action or method to break ViewTransitions' form submission

Before

<form action="foo">
 <input name="action" value="bar">
</form>

Submission would result in a broken route GET /[object%20HTMLInputElement] since form.action now points to an HTML element.

After

Form submission handler tests action to be a string, and if not reads the action using form.getAttribute

Testing

• Added two additional e2e tests of scenarios that would break without this fix.
• Existing tests enhanced my fix to have more rigorous checking of attributes

Docs

No docs changed needed

[changeset-bot]

🦋 Changeset detected

Latest commit: 631d336

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[martrapp]

Took me a while to understand but now looks very good to me!
Also thank you very much for adding the tests!

(would only be slightly better with a capital M in formMethod ;-)

[robertvanhoesel]

(would only be slightly better with a capital M in formMethod ;-)

@martrapp Oh hey that is definitely meant to have a capital M. Fixed!

[martrapp]

Thank you so much ;-)!
Will give @matthewp a chance to approve, if he finds time.

[matthewp]

wonderful tests