Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip crawling into CSS requests when crawling module graph #10911

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 30, 2024

Changes

Unblocks vitejs/vite#16455

We were crawling into dependencies of CSS vite modules, which are usually not needed as these dependencies (especially CSS) are already inlined into the parent vite module.

In practice, this doesn't change the output as we coincidentally these dependencies don't have an id:

for (const importedModule of entry.importedModules) {
if (!importedModule.id) continue;

So they were skipped. But vitejs/vite#16455 will change things slightly that makes this not work, so this PR makes this skip more explicit.

Testing

Ran tests locally, and tested an example manually.

Docs

n/a. internal change.

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 7ef09fb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 30, 2024
@bluwy bluwy merged commit a86dc9d into main Apr 30, 2024
13 checks passed
@bluwy bluwy deleted the css-crawl-away branch April 30, 2024 09:06
@astrobot-houston astrobot-houston mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants