Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when accessing clientAddress on prerendered routes #10977

Merged
merged 8 commits into from
May 9, 2024

Conversation

BryceRussell
Copy link
Member

@BryceRussell BryceRussell commented May 8, 2024

Changes

  • What does this change?

Closes: #10972

  • Add adapter name to dev manifest
  • Add error message for accessing clientAddress on prerendered routes
  • Fix/Throw error when accessing clientAddress on prerendered routes

Testing

I am not sure how to test this, I tested it manually. If someone could point me to an example, that would be great!

Docs

Does not change behavior, just throws a different error

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: b9cb397

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr A PR that includes documentation for review labels May 8, 2024
@BryceRussell BryceRussell marked this pull request as draft May 8, 2024 18:28
@BryceRussell BryceRussell marked this pull request as ready for review May 8, 2024 18:57
@ematipico
Copy link
Member

Should we add a changeset for a patch?

@bluwy bluwy merged commit 59571e8 into main May 9, 2024
13 checks passed
@bluwy bluwy deleted the fix-clientAddress-error branch May 9, 2024 08:16
@astrobot-houston astrobot-houston mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro.clientAddress is not available in the @astrojs/node adapter.
3 participants