Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hoisted scripts propagation #11084

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix hoisted scripts propagation #11084

merged 2 commits into from
May 17, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 17, 2024

Changes

fix #11063

regression from #10959. When there's two hoisted scripts for a propagated asset (eg mdx file in content collection), there's two sets and I was incorrectly replacing the older with the new one. This PR fixes it and combines the set instead.

Testing

Added a new test

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: d51dec5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 17, 2024
@bluwy bluwy merged commit 9637014 into main May 17, 2024
4 checks passed
@bluwy bluwy deleted the fix-hoisted-script-propagation branch May 17, 2024 10:11
@astrobot-houston astrobot-houston mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imported components in mdx content collection pages lose client scripts
2 participants