Expose inferRemoteSize function
#11098
Conversation
🦋 Changeset detectedLatest commit: 934a54f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Refactored it a bit, the only thing missing will be adding better error messages now that this is exposed and stuff. I'll do that later, thank you for contributing! |
|
Thank you, as always, @Princesseuh! |
|
@itsmatteomanf please ping me when this PR is ready to be shipped. Do you think it will be ready for the next minor? |
|
@ematipico as far as I am concerned it's ready, I know @Princesseuh had some changes in mind though, but said she was going to do them herself... |
|
Yeah, will tackle when I'm back from holidays if no one does. The changes required are just making the errors better, now that the feature is exposed. Docs might be great as well! |
There was a problem hiding this comment.
Blocking this while we figure out what docs are needed!
The current docs for inferSize are here: https://docs.astro.build/en/guides/images/#infersize so this would be a place to check.
Also checking that we don't need any new error messages associated with making this available to users now?
Additionally, adding the necessary context (why this PR was made, what this allows you to do) inside the PR description rather than linking to a Discord message (not publicly available) is helpful! This would have helped me suggest an appropriate changeset message.
|
Hmm, okay there's a problem with exporting it from |
There was a problem hiding this comment.
Fantastic example, thank you @Princesseuh ! One quick thought for your consideration, but happy for you to make the final call.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
| @@ -1,4 +1,4 @@ | |||
| export { emitESMImage } from './emitAsset.js'; | |||
| export { emitESMImage } from './node/emitAsset.js'; | |||
There was a problem hiding this comment.
So this is annoying, emitAsset (obviously) isn't non-Node safe, but I exported it from the utils without thinking a while ago, and now it means that astro:assets can't actually import from astro/assets/utils otherwise it breaks runtime.
For now, I moved emitAsset to its own folder to reduce damage, and in the future I'll update the Markdoc integration and stuff to import it from the proper place.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
* feat: expose and rename `inferSize` * feat: separate `ISize` type * feat: reformat function to use `ImageMetadata` * nit(assets): re-use image-metadata code for remote images * chore: changeset * chore: changeset * feat(assets): Export from `astro:assets` * fix: proper errors * fix: dont export from astro/assets * fix: ests * Update .changeset/large-geese-play.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * fix: ests * Update .changeset/large-geese-play.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> --------- Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
This change exposes the old
inferSize(), renamed toinferRemoteSize()per https://discord.com/channels/830184174198718474/1240790957591367701.Testing
No additional testing needed, it was never tested directly.
Docs
withastro/docs#8808