Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prefer using x-forwarded-for as clientAddress #11101

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: prefer using x-forwarded-for as clientAddress #11101

merged 7 commits into from
May 22, 2024

Conversation

linguofeng
Copy link
Contributor

Changes

Added logic to extract the client's IP address from the request headers (x-forwarded-for)

Testing

CI should pass

Docs

N/A

@linguofeng
feat: change node clientAddress use x-forwarded-for
72180e4 
when

```
adapter: node({
    mode: 'standalone',
  })
```
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 20, 2024 •
edited

🦋 Changeset detected

Latest commit: 9155b81

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 20, 2024
ematipico
ematipico requested changes May 20, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a changeset?

This seems to be a new feature, so we should flag it as a minor.

Plus, we require a test, since we are adding new stuff. Just accepting the current CI isn't enough.

@github-actions github-actions bot added the semver: major Change triggers a `major` release label May 21, 2024
github-actions[bot]
github-actions bot previously requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a major changeset. A reviewer will merge this at the next release if approved.

ematipico
ematipico requested changes May 21, 2024
View reviewed changes
.changeset/healthy-planets-dream.md Outdated Show resolved Hide resolved
.changeset/healthy-planets-dream.md Outdated Show resolved Hide resolved
linguofeng and others added 2 commits May 21, 2024 18:01
@linguofeng @ematipico
Update .changeset/healthy-planets-dream.md
96ec026 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@linguofeng @ematipico
Update .changeset/healthy-planets-dream.md
f7c2a30 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@ematipico ematipico added this to the 4.9.0 milestone May 21, 2024
@florian-lefebvre florian-lefebvre added semver: minor Change triggers a `minor` release and removed semver: major Change triggers a `major` release labels May 21, 2024
@ematipico ematipico merged commit a6916e4 into withastro:main May 22, 2024
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linguofeng @matthewp @ematipico @florian-lefebvre