Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown bug bash! #1789

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Markdown bug bash! #1789

merged 4 commits into from
Nov 10, 2021

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Manually. Before it did not work, now it does work.

Docs

Bug fixes

@natemoo-re natemoo-re requested a review from a team as a code owner November 10, 2021 22:25
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

🦋 Changeset detected

Latest commit: 5d57b53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/markdown-remark Patch
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re natemoo-re added this to the v0.21 milestone Nov 10, 2021
return function (node: any): any {
return visit(node, 'element', (el) => {
if (el.tagName === 'code' || el.tagName === 'pre') {
el.properties['data-astro-raw'] = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@drwpow
Copy link
Member

drwpow commented Nov 10, 2021

This looks good! But lemme try a markdown file that had been breaking for me before

@drwpow
Copy link
Member

drwpow commented Nov 10, 2021

This works great! It successfully builds more advanced markdown that worked in 0.20 but not in earlier versions of 0.21. ✅

@natemoo-re natemoo-re merged commit 7eaabbb into main Nov 10, 2021
@natemoo-re natemoo-re deleted the fix/markdown-content branch November 10, 2021 23:34
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants