Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of preprocessors with the static build #2490

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • In order to fix HMR a change was made to the static build which prevented preprocessing, thinking that the module would be preprocessed later.
  • This was a mistake, we have to preprocess because scoping happens in the compiler. So this restores preprocessing for the static build.

Testing

Updated the example app.

Docs

Bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2022

🦋 Changeset detected

Latest commit: d1c29bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) labels Jan 28, 2022
@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: f8c6305

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f464554e3de500073e235b

😎 Browse the preview: https://deploy-preview-2490--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: d1c29bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f4648268f67700074c2c0f

😎 Browse the preview: https://deploy-preview-2490--astro-docs-2.netlify.app

Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Fancy fill work, too.

@matthewp matthewp merged commit 69d5b70 into main Jan 28, 2022
@matthewp matthewp deleted the static-build-scss branch January 28, 2022 22:10
@github-actions github-actions bot mentioned this pull request Jan 28, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix use of preprocessors with the static build

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants