Fix/2177/log missing local network ip #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f4df75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
reviewed
Mar 8, 2022
natemoo-re
reviewed
Mar 8, 2022
natemoo-re
reviewed
Mar 8, 2022
Comment on lines
+31
to
+33
| const { type = 'module', version, dependencies = {} } = await fs.readFile('./package.json').then((res) => JSON.parse(res.toString())); | ||
| // expose PACKAGE_VERSION on process.env for CLI utils | ||
| config.define = { 'process.env.PACKAGE_VERSION': JSON.stringify(version) }; |
There was a problem hiding this comment.
We were already reading the local package.json file anyway, so we can inject whatever metadata we need during build
natemoo-re
approved these changes
Mar 8, 2022
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* feat: show "localhost" for local network IPs * refactor: remove timestamps from addr logs * fix: hide timestamp on null types * feat: add emoji OS helper * feat: make logs 100% nicer * refactor: extract isLocalHost to util * feat: update preview logs to match * chore: add changeset * fix: pull pkg version from package.json * refactor: remove 👉 guys * fix: devStart return type * feat: inject process.env.PACKAGE_VERSION at build time * feat: update unit test for hostname checks Co-authored-by: Nate Moore <nate@skypack.dev>
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* feat: show "localhost" for local network IPs * refactor: remove timestamps from addr logs * fix: hide timestamp on null types * feat: add emoji OS helper * feat: make logs 100% nicer * refactor: extract isLocalHost to util * feat: update preview logs to match * chore: add changeset * fix: pull pkg version from package.json * refactor: remove 👉 guys * fix: devStart return type * feat: inject process.env.PACKAGE_VERSION at build time * feat: update unit test for hostname checks Co-authored-by: Nate Moore <nate@skypack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
devOptions.hostnamenot displaying local network IP. #2177--hostname=127.0.0.1,--hostname=0.0.0.0, no hostname provided--hostnameIP for all other IPsTesting
Manually tested with different
--hostnamearguments.Docs
N/A